Skip to content

Commit

Permalink
Version Bump and fix build error (#297)
Browse files Browse the repository at this point in the history
- Compile/Target SDK: 33 -> 34
- androidx navigation: 2.6.0 -> 2.7.0
- compose compiler: 1.5.0 -> 1.5.1
- compose bom: 06.01 -> 08.00
- compose destination: 1.9.42-beta -> 1.9.52
  • Loading branch information
l2hyunwoo authored Aug 11, 2023
1 parent 183dd7b commit 68ab68a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,14 @@ fun ImageContent(
isEditable: Boolean
) {
val isImageEmpty = remember(imageModel) { imageModel.isEmpty() }
val pagerState = rememberPagerState { imageModel.size }
val photoPickerLauncher = rememberLauncherForActivityResult(ActivityResultContracts.PickMultipleVisualMedia()) {
if (it.isNotEmpty()) {
onChangeImage(ImageModel.Local(it))
}
}

HorizontalPager(imageModel.size) { page ->
HorizontalPager(state = pagerState) { page ->
Box(
modifier = Modifier
.fillMaxWidth()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fun OnboardingScreen(
navigator: DestinationsNavigator
) {
val onboardingPages = OnBoardingPageUiModel.values()
val pageState = rememberPagerState()
val pageState = rememberPagerState { onboardingPages.size }
SoptTheme {
SoptColumn(
modifier = Modifier
Expand All @@ -93,8 +93,7 @@ fun OnboardingScreen(
)
HorizontalPager(
modifier = Modifier.fillMaxWidth(),
state = pageState,
pageCount = onboardingPages.size
state = pageState
) {
OnboardingPage(
image = onboardingPages[pageState.currentPage].image,
Expand Down
12 changes: 6 additions & 6 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[versions]
compileSdk = "33"
compileSdk = "34"
minSdk = "28"
targetSdk = "33"
targetSdk = "34"
appVersion = "1.0.1"
versionCode = "10001"

Expand All @@ -14,11 +14,11 @@ corektx = "1.10.1"
appcompat = "1.6.1"
activity = "1.7.2"
lifecycle = "2.6.1"
navigation = "2.6.0"
navigation = "2.7.0"
startup = "1.1.1"
security = "1.1.0-alpha06"
compose-compiler = "1.5.0"
compose-bom = "2023.06.01"
compose-compiler = "1.5.1"
compose-bom = "2023.08.00"
desugarJdk = "2.0.3"
rxjava = "3.1.6"
rxkotlin = "3.0.1"
Expand Down Expand Up @@ -51,7 +51,7 @@ soloader = "0.10.5"
okhttp = "4.11.0"
retrofit = "2.9.0"
timber = "5.0.1"
compose-destination = "1.9.42-beta"
compose-destination = "1.9.52"
mavericks = "3.0.6"
coil = "2.4.0"
lottie = "6.1.0"
Expand Down

0 comments on commit 68ab68a

Please sign in to comment.