fix keras example #1498
Closed
fix keras example #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot ! Nothing obviously wrong here, even if I'm not a python or TF specialist. Can you just rename no-ci.sh to |
|
Superseded by #1499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and good day,
This pull request addresses the following issue: Fix Keras example #1352. The changes made in this PR include:
The "examples/keras-tract-tf2/requirements.txt" file was changed to remove library conflicts.
The "examples/keras-tract-tf2/no-ci.sh" bash file was changed to use Python 3.8.
The "examples/keras-tract-tf2/example.py" Python file was fixed.
The "examples/keras-tract-tf2/.gitignore" was slightly changed to ignore the Python virtual environment (venv) from being pushed.
A slight change was also made to "examples/face_detection_yolov8onnx_example/Cargo.toml" to remove a warning during the build.
I have tested the changes on my Fedora system, and everything seems to be working fine. I would appreciate it if you could take a moment to review the changes. If everything looks good, please merge this pull request at your convenience. If there are any concerns or further modifications needed, please let me know, and I'll be happy to address them.
Best Regards,
Akbar Banitalebi