-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 8.8 #165
Update to Gradle 8.8 #165
Conversation
…10) * automate release to central, including close/release of staging repo
…ublish didn't fire).
…blish just in case.
…time for staging repo to close.
…epo to close/release. Also manually increment release number because prior failed release did manage to get published.
Co-authored-by: Guillermo Varela <[email protected]>
There is a known issue with Gradle and multi-jar dependencies on plugins, which happen to be the case of Jackson as of version 2.15.0-rc1. While a workaround could be using resolution strategy to force a downgraded version it's hard to determine the impact (specially medium/long term) of using an older dependency version. It migth be better just to work with what Gradle allow us to on each version where they fixed (or backported) the issue:
f82df5c adds tests for the known Gradle version this plugin would be able to support. |
Fully in agreement with this. We probably need to update the readme or version 3 of this plugin, to state which gradle versions are supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Please check if this is good enough: https://github.com/sonatype-nexus-community/scan-gradle-plugin/pull/165/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 |
310a2c0
to
3f73378
Compare
Goes up until the more recent Gradle version we can use without introducing breaking changes.
I'd prefer to deal with those changes later when we upgrade to Gradle 9 (which isn't yet at GA).
cc @bhamail / @DarthHater / @shaikhu