Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 8.8 #165

Closed
wants to merge 299 commits into from
Closed

Update to Gradle 8.8 #165

wants to merge 299 commits into from

Conversation

guillermo-varela
Copy link
Contributor

Goes up until the more recent Gradle version we can use without introducing breaking changes.

I'd prefer to deal with those changes later when we upgrade to Gradle 9 (which isn't yet at GA).

cc @bhamail / @DarthHater / @shaikhu

bhamail and others added 30 commits January 21, 2020 17:11
…10)

* automate release to central, including close/release of staging repo
…epo to close/release. Also manually increment release number because prior failed release did manage to get published.
@guillermo-varela
Copy link
Contributor Author

guillermo-varela commented Sep 27, 2024

There is a known issue with Gradle and multi-jar dependencies on plugins, which happen to be the case of Jackson as of version 2.15.0-rc1.

While a workaround could be using resolution strategy to force a downgraded version it's hard to determine the impact (specially medium/long term) of using an older dependency version.

It migth be better just to work with what Gradle allow us to on each version where they fixed (or backported) the issue:

f82df5c adds tests for the known Gradle version this plugin would be able to support.

@shaikhu
Copy link
Contributor

shaikhu commented Sep 27, 2024

There is a known issue with Gradle and multi-jar dependencies on plugins, which happen to be the case of Jackson as of version 2.15.0-rc1.

While a workaround could be using resolution strategy to force a downgraded version it's hard to determine the impact (specially medium/long term) of using an older dependency version.

It migth be better just to work with what Gradle allow us to on each version where they fixed (or backported) the issue:

Fully in agreement with this. We probably need to update the readme or version 3 of this plugin, to state which gradle versions are supported.

Copy link
Contributor

@shaikhu shaikhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@paul-botsco-2-0 paul-botsco-2-0 bot added 😒 commits missing author Commits are missing author information - this must be resolved 😧 commits missing verification Some commits are not signed - this must be resolved labels Sep 27, 2024
@guillermo-varela
Copy link
Contributor Author

We probably need to update the readme or version 3 of this plugin, to state which gradle versions are supported.

Please check if this is good enough: https://github.com/sonatype-nexus-community/scan-gradle-plugin/pull/165/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

@shaikhu shaikhu removed 😒 commits missing author Commits are missing author information - this must be resolved 😧 commits missing verification Some commits are not signed - this must be resolved labels Oct 1, 2024
@shaikhu shaikhu closed this Oct 10, 2024
@paul-botsco-2-0 paul-botsco-2-0 bot added the 😒 commits missing author Commits are missing author information - this must be resolved label Oct 10, 2024
@paul-botsco-2-0
Copy link

Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set.

The commits to review are:

@shaikhu shaikhu deleted the update_gradle branch October 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😒 commits missing author Commits are missing author information - this must be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.