Add support for v4 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtapia
force-pushed
the
support/v4
branch
2 times, most recently
from
47a04e7
to
1d97ab3
Compare
tvdeyen
requested changes
Sep 26, 2023
| run-specs-with-postgres: | ||
| executor: | ||
| name: solidusio_extensions/postgres | ||
| ruby_version: "3.2" | ||
| ruby_version: "3.0" |
There was a problem hiding this comment.
Why have you changed the tested ruby version?
| run-specs-with-mysql: | ||
| executor: | ||
| name: solidusio_extensions/mysql | ||
| ruby_version: "3.1" |
There was a problem hiding this comment.
Same here. Please do not change test config
| recent activity. It will be closed if no further activity occurs. Thank you | ||
| for your contributions. | ||
| # Comment to post when closing a stale issue. Set to `false` to disable | ||
| closeComment: false |
There was a problem hiding this comment.
Is this change related to the Solidus 4.0 upgrade? If yes, can you explain why?
| @@ -0,0 +1,2 @@ | |||
| issues=false | |||
| exclude-labels=infrastructure | |||
There was a problem hiding this comment.
Where does this change came from? Can you make this a separate commit.
| Rails/SkipsModelValidations: | ||
| Exclude: | ||
| - db/migrate/**/* | ||
| NewCops: disable |
There was a problem hiding this comment.
This change also qualifies a separate commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.