storage: fix ssr handling

solidjs-community · Jul 14, 2024 · b9d7b28 · b9d7b28
1 parent 46f6d8f
commit b9d7b28
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/lovely-singers-rescue.md b/.changeset/lovely-singers-rescue.md
@@ -0,0 +1,5 @@
+---
+"@solid-primitives/storage": minor
+---
+
+fix ssr handling
diff --git a/packages/storage/src/persisted.ts b/packages/storage/src/persisted.ts
@@ -69,12 +69,12 @@ export function makePersisted<
   T = SignalType<S>,
 >(signal: S, options: PersistenceOptions<T, O> = {} as PersistenceOptions<T, O>): S {
   const storage = options.storage || globalThis.localStorage;
+  const name = options.name || `storage-${createUniqueId()}`;
   // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   if (!storage) {
     return signal;
   }
   const storageOptions = (options as unknown as { storageOptions: O }).storageOptions;
-  const name = options.name || `storage-${createUniqueId()}`;
   const serialize: (data: T) => string = options.serialize || JSON.stringify.bind(JSON);
   const deserialize: (data: string) => T = options.deserialize || JSON.parse.bind(JSON);
   const init = storage.getItem(name, storageOptions);