fix: allow typescript-eslint@8 as dependency #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Aug 5, 2024
| export function findVariable( | ||
| context: CompatContext, | ||
| node: TSESTree.Identifier | ||
| ): TSESLint.Scope.Variable | null { |
There was a problem hiding this comment.
Without this:
src/compat.ts:36:17 - error TS2742: The inferred type of 'findVariable' cannot be named without a reference to '.pnpm/@[email protected]/node_modules/@typescript-eslint/scope-manager'. This is likely not portable. A type annotation is necessary.
36 export function findVariable(
~~~~~~~~~~~~
JoshuaKGoldberg
commented
Aug 5, 2024
| @@ -1,1606 +1,3282 @@ | |||
| lockfileVersion: '6.0' | |||
| lockfileVersion: '9.0' | |||
There was a problem hiding this comment.
Which version of pnpm does this repo require? I'm on a newer one, so this lockfile got pretty significantly changed here.
There was a problem hiding this comment.
Currently, there is no packageManager field, so there is no predefined version to use. When you used a newer version of pnpm, it probably added a packageManager field to the package.json
There was a problem hiding this comment.
Yup, I was hoping to be told what version is preferred so I can just go with that - instead of changing a bunch of things.
pauliesnug
approved these changes
Aug 13, 2024
|
Thanks so much for this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148.
Sending as a draft for reference in case it's useful. Cheers! 😄Now that typescript-eslint@8 is released, this is ready for review + merge IMO.