Add bolt reconnection parameter: jraft.bolt.conn.reconnect #1136
Conversation
WalkthroughThe recent changes improve the Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant RPC as RpcOptions
participant Client as BoltRpcClient
User->>RPC: Set enableBoltReconnect(true/false)
Client->>RPC: Get enableBoltReconnect status
alt Reconnect Enabled
Client->>Client: Call enableReconnectSwitch()
else Reconnect Disabled
Client->>Client: Call disableReconnectSwitch()
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- jraft-core/src/main/java/com/alipay/sofa/jraft/option/RpcOptions.java (3 hunks)
- jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/BoltRpcClient.java (1 hunks)
Additional comments not posted (5)
jraft-core/src/main/java/com/alipay/sofa/jraft/option/RpcOptions.java (4)
66-70: LGTM! The addition of theenableBoltReconnectproperty is well-implemented.The property is initialized using a system property with a default value of
true, which provides flexibility and configurability.
128-130: LGTM! TheisEnableBoltReconnectmethod is correctly implemented.The method serves as a straightforward getter for the
enableBoltReconnectproperty.
132-134: LGTM! ThesetEnableBoltReconnectmethod is correctly implemented.The method serves as a straightforward setter for the
enableBoltReconnectproperty.
141-142: LGTM! ThetoStringmethod update is correctly implemented.The method now includes the
enableBoltReconnectfield, enhancing the string representation of theRpcOptionsobject.jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/BoltRpcClient.java (1)
60-64: LGTM! The conditional logic in theinitmethod is correctly implemented.The method now conditionally enables or disables the reconnect feature based on the
opts.isEnableBoltReconnect()value, enhancing the flexibility of the RPC client setup.
jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/BoltRpcClient.java
Outdated
Show resolved
Hide resolved
shihuili1218
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/BoltRpcClient.java (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/BoltRpcClient.java
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.
Summary by CodeRabbit
New Features
Improvements