Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix and improve some logs #1122

Closed
wants to merge 1 commit into from
Closed

chore: fix and improve some logs #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ private boolean initMetaStorage() {
RaftMetaStorageOptions opts = new RaftMetaStorageOptions();
opts.setNode(this);
if (!this.metaStorage.init(opts)) {
LOG.error("Node {} init meta storage failed, uri={}.", this.serverId, this.options.getRaftMetaUri());
LOG.error("Node {} init meta storage failed, uri={}.", this.nodeId, this.options.getRaftMetaUri());
return false;
}
this.currTerm = this.metaStorage.getTerm();
Expand Down
4 changes: 2 additions & 2 deletions jraft-core/src/main/java/com/alipay/sofa/jraft/storage/impl/LogManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public boolean init(final LogManagerOptions opts) {
this.writeLock.lock();
try {
if (opts.getLogStorage() == null) {
LOG.error("Fail to init log manager, log storage is null");
LOG.error("Fail to init log manager, log storage is null, groupId={}", opts.getGroupId());
return false;
}
this.groupId = opts.getGroupId();
Expand All @@ -182,7 +182,7 @@ public boolean init(final LogManagerOptions opts) {
lsOpts.setLogEntryCodecFactory(opts.getLogEntryCodecFactory());

if (!this.logStorage.init(lsOpts)) {
LOG.error("Fail to init logStorage");
LOG.error("Fail to init logStorage, groupId={}", this.groupId);
return false;
}
this.firstLogIndex = this.logStorage.getFirstLogIndex();
Expand Down
1 change: 1 addition & 0 deletions ...sion/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/AbstractDB.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public boolean init(final LogStoreFactory logStoreFactory) {
this.abortFile = new AbortFile(abortFilePath);
this.serviceManager = logStoreFactory.newServiceManager(this);
if (!this.serviceManager.init(logStoreFactory)) {
LOG.warn("Fail to init service manager for {}", getDBName());
return false;
}
this.fileManager = logStoreFactory.newFileManager(getDBFileType(), this.storePath,
Expand Down
Loading