Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change type and function to calc tokens in message #166

Merged
merged 3 commits into from
Jun 27, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions crates/llm-chain-openai/src/chatgpt/executor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use llm_chain::tokens::TokenCollection;

use super::prompt::create_chat_completion_request;
use super::prompt::format_chat_messages;
use async_openai::error::OpenAIError;
use async_openai::{error::OpenAIError, types::ChatCompletionRequestMessage};
use llm_chain::prompt::Prompt;

use llm_chain::tokens::PromptTokensError;
Expand All @@ -19,7 +19,7 @@ use llm_chain::traits::{ExecutorCreationError, ExecutorError};
use async_trait::async_trait;
use llm_chain::tokens::TokenCount;

use tiktoken_rs::async_openai::num_tokens_from_messages;
use tiktoken_rs::get_chat_completion_max_tokens;

use std::sync::Arc;

Expand Down Expand Up @@ -109,9 +109,12 @@ impl traits::Executor for Executor {
) -> Result<TokenCount, PromptTokensError> {
let opts_cas = self.cascade(Some(opts));
let model = self.get_model_from_invocation_options(&opts_cas);
let messages = format_chat_messages(prompt.to_chat())?;
let tokens_used = num_tokens_from_messages(&model, &messages)
.map_err(|_| PromptTokensError::NotAvailable)?;
let messages: Vec<ChatCompletionRequestMessage> = format_chat_messages(prompt.to_chat())?;
let no_messages: Vec<tiktoken_rs::ChatCompletionRequestMessage> = Vec::new();
let tokens_used = get_chat_completion_max_tokens(&model, no_messages.as_slice())
.map_err(|_| PromptTokensError::NotAvailable)?
- get_chat_completion_max_tokens(&model, as_tiktoken_messages(messages).as_slice())
.map_err(|_| PromptTokensError::NotAvailable)?;

Ok(TokenCount::new(
self.max_tokens_allowed(opts),
Expand All @@ -136,6 +139,22 @@ impl traits::Executor for Executor {
}
}

fn as_tiktoken_message(
message: &ChatCompletionRequestMessage,
) -> tiktoken_rs::ChatCompletionRequestMessage {
tiktoken_rs::ChatCompletionRequestMessage {
role: message.role.to_string(),
content: message.content.clone(),
name: message.name.clone(),
}
}

fn as_tiktoken_messages(
messages: Vec<ChatCompletionRequestMessage>,
) -> Vec<tiktoken_rs::ChatCompletionRequestMessage> {
messages.iter().map(|x| as_tiktoken_message(x)).collect()
}

pub struct OpenAITokenizer {
model_name: String,
}
Expand Down
Loading