Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More new lamps #402

Closed
wants to merge 60 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
7bdd209
Added colored logs
simontorres Jun 4, 2021
d781506
Added more logging messages
simontorres Jun 9, 2021
a9bb70b
Modified cross correlation function to allow center-bias results. For…
simontorres Jun 9, 2021
8a2d65f
Fixed bug where the DCLOG1 keyword contained the wrong lamp name used.
simontorres Jun 9, 2021
49990ee
Increase `radeg` and `decdeg` precision to 6 decimal numbers. closes …
simontorres Jun 10, 2021
2220fd1
Renamed astropy's model BlackBody1D to BlackBody to be updated with p…
simontorres Aug 12, 2021
a9ce824
Removed NoMatchFound exception in get_reference_lamp
simontorres Nov 24, 2021
0cff6a3
Created Interactive Extraction class
simontorres Nov 24, 2021
eabe200
wrapped show maximized in try/except statement
simontorres Nov 24, 2021
d47aa91
Added create reference lamp method
simontorres Nov 24, 2021
11c9031
fixed core tests for removal of NoMatchFound exception
simontorres Nov 24, 2021
d0f4436
fixed text to consider new error message
simontorres Nov 24, 2021
1cfc016
added GSP's wcs keywords to lamps
simontorres Nov 24, 2021
9d179df
Added better debug message for when a lamp is found or not
simontorres Nov 24, 2021
80e0cc6
set mask to None for extracted targets and modified tests accordingly
simontorres Nov 24, 2021
5cbc644
changed exception from NotImplemented to NotImplementedError
simontorres Nov 24, 2021
e2e3561
renamed interpolate method in core to interpolate_spectrum to avoid c…
simontorres Nov 24, 2021
2c3a3f5
Removed import scipy in favor of from scipy import signal, interpolate
simontorres Nov 24, 2021
4d26a72
set version to 1.3.5
simontorres Nov 24, 2021
cb3e384
updated change history and set release date
simontorres Nov 24, 2021
52ccee5
process imaging data taken with FILTER2
SunilSimha Jan 16, 2022
6692357
Replaced HgArNe lamps for 600Mid GG395 (new filter, old was GG385) an…
simontorres Mar 26, 2022
b590f75
Changed version to 1.3.6
simontorres Mar 26, 2022
37f1e6c
Fixed deprecation warning
simontorres Mar 26, 2022
6a740c2
Updated Change History
simontorres Mar 26, 2022
0f920a6
Fixed big size of files
simontorres Mar 26, 2022
0f692e1
corrected exception
simontorres Mar 26, 2022
98b25bd
small docs updates
simontorres Nov 14, 2022
6f704b3
adding a resample option to save_science_data
simontorres Nov 14, 2022
dd1c173
pipe through --ignore-bias to create_master_flats
griffin-h Mar 25, 2022
ee7b4a5
Update prject to lastest changes
simontorres Mar 21, 2024
b6b6e1b
Removed some files and some unused dependencies
simontorres Mar 21, 2024
6418dbe
Changed middle click to right click event to save point, also added p
simontorres Mar 21, 2024
7a7f9f1
Brought back interactive wavelength calibration call
simontorres Mar 21, 2024
2fd31ee
Add new save method with linearizing as an option
simontorres Apr 3, 2024
3b782a8
rename add_wavelength_solution to add_linear_wavelength solution
simontorres Apr 3, 2024
e68c533
improve help texts and added keystroke commmand. p to add new point
simontorres Apr 3, 2024
d9b575f
Renamed redspec class from MainApp to RedSpec
simontorres Apr 8, 2024
c3f1d65
rename MainApp to RedCCD and RedSpec respectively
simontorres Apr 8, 2024
7c783d9
rename function add_wcs_keys to add_linear_wcs_keys
simontorres Apr 8, 2024
cffbafe
remove premature addition of linear wcs keys to file headers
simontorres Apr 8, 2024
aae3d94
Create single function to record wavelength solution evaluation
simontorres Apr 8, 2024
a87561c
implementation of function to record wavelength solution evaluations
simontorres Apr 8, 2024
e442f32
using a single function to record linear wavelength solution
simontorres Apr 8, 2024
4044c9b
apply flake8 corrections
simontorres Apr 12, 2024
8dfd1dd
Add GSP_LINE keyword for linearized data, add typing to WavelenthCali…
simontorres Apr 12, 2024
714cef9
update instance name
simontorres Apr 12, 2024
6396cb9
Remove out of scope file
simontorres Apr 12, 2024
ef7c50c
rename attribute calibration_lampt to more explicit comparison_lamp_f…
simontorres Apr 12, 2024
5443816
re implement interactive wavelength calibration, removed duplicated c…
simontorres Apr 12, 2024
71f952e
changed typing for path
simontorres Apr 12, 2024
990b913
change of supported python versions
simontorres Apr 12, 2024
f389eec
remove wrong import
simontorres Apr 12, 2024
e4a2d8e
comment unused code
simontorres Apr 12, 2024
1abfe28
add missing requirement
simontorres Apr 12, 2024
b5b3968
add missing requirement
simontorres Apr 12, 2024
e78122c
Merge branch 'main' of github.com:soar-telescope/goodman_pipeline int…
Allonck Apr 15, 2024
6d4e6a6
Merge remote-tracking branch 'simon/improve_cross_correlation' into i…
Allonck Apr 17, 2024
447231d
Add 2100_3900A lamp
Allonck May 10, 2024
4726b5a
Add 2100_650nm lamp
Allonck May 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -48,5 +48,3 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
fail_ci_if_error: true # optional (default = false)


3 changes: 2 additions & 1 deletion docs/change_history.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Change History
##############


.. _v1.3.8:

V1.3.8 Not Released
Expand Down Expand Up @@ -112,7 +113,7 @@ V1.3.0 06-03-2020
- Removed bias overscan and trimming correction on master bias creation.
- Bugs Fixed:

+ `--max-targets` was not being used, missed connection in `MainApp`.
+ `--max-targets` was not being used, missed connection in `RedSpec`.

- Updated keyword values of all reference lamps in the library according to [#292]
- Refactored `wavelength.WavelengthCalibration` class moving several methods to
Expand Down
4 changes: 0 additions & 4 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,6 @@
'Miscellaneous'),
]



# -- Options for Epub output ----------------------------------------------

# Bibliographic Dublin Core info.
Expand All @@ -207,5 +205,3 @@

# A list of files that should not be packed into the epub file.
epub_exclude_files = ['search.html']


1 change: 1 addition & 0 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ dependencies:
- pydata-sphinx-theme
- astroplan
- mock
- setuptools
- sphinx
- sphinxcontrib.napoleon
4 changes: 3 additions & 1 deletion goodman_pipeline/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# flake8: noqa

from __future__ import absolute_import

from .version import __version__
Expand All @@ -6,4 +8,4 @@
from . import images
from . import core

from .core import setup_logging
from .core import setup_logging
5 changes: 4 additions & 1 deletion goodman_pipeline/core/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# flake8: noqa

from __future__ import (absolute_import, division, print_function,
unicode_literals)

Expand All @@ -13,7 +15,7 @@

# import of functions in core.py
from .core import (astroscrappy_lacosmic,
add_wcs_keys,
add_linear_wcs_keys,
add_linear_wavelength_solution,
bin_reference_data,
call_cosmic_rejection,
Expand Down Expand Up @@ -52,6 +54,7 @@
recenter_broad_lines,
recenter_lines,
record_trace_information,
record_wavelength_solution_evaluation,
save_extracted,
search_comp_group,
setup_logging,
Expand Down
Loading
Loading