Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cache in Bluesky #627

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Fix cache in Bluesky #627

merged 2 commits into from
Nov 5, 2023

Conversation

JoelOtter
Copy link
Contributor

snarfed
snarfed reviewed Nov 5, 2023
View reviewed changes
Copy link
Owner

@snarfed snarfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Mind updating the existing get_activities tests to pass in a cache and check that the cached counts that come out are ok?

@snarfed
Copy link
Owner

snarfed commented Nov 5, 2023

Thanks! Deploying now.

@snarfed snarfed merged commit 24620ce into snarfed:main Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarfed snarfed Awaiting requested review from snarfed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bluesky: look into optimizing API calls
2 participants
@JoelOtter @snarfed