Dev #387
Merged
Dev #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
align branches
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
| break | ||
|
|
||
| if loop > 12: | ||
| await channel.send(f"<@448777271701143562> Mining endpoint not responding!\n") |
There was a problem hiding this comment.
Suggested change
| await channel.send(f"<@448777271701143562> Mining endpoint not responding!\n") | |
| await channel.send("<@448777271701143562> Mining endpoint not responding!\n") |
f-string is unnecessary here. This can just be a string. More.
| seconds -= value * count | ||
| if value == 1: | ||
| name = name.rstrip('s') | ||
| result.append("{} {}".format(value, name)) |
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. More info.
|
|
||
| load_dotenv() | ||
|
|
||
| class JsonSerde(object): # pragma: no cover |
There was a problem hiding this comment.
Suggested change
| class JsonSerde(object): # pragma: no cover | |
| class JsonSerde: # pragma: no cover |
JsonSerde inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. More.
| notary_list = get_notary_list(season) | ||
| def get_daily_stats_sorted(notary_list, dpow_coins_dict): | ||
| logger.info("get_daily_stats_sorted") | ||
| cache_key = f"daily_stats_sorted" |
There was a problem hiding this comment.
Suggested change
| cache_key = f"daily_stats_sorted" | |
| cache_key = "daily_stats_sorted" |
f-string is unnecessary here. This can just be a string. Explained here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.