Use smithy official formatter #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
We've implemented support for formatting via the formatter in smithy-translate but now that the official formatter is out, there is no reason not to use it.
In my own tests, the official formatter produce different results but it is more consistent. Our modeling of the AST is wrong when it comes to whitespaces and as such we produce poorly formatted files when comments are extensively used. For example, this recent issue highlight a simple snippet that is poorly formatted. The official formatter does the correct thing here.
I'd be happy to add some tests if you like this PR. Feel free to push changes to this PR if you want to do it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.