add log for missing name in DocumentSymbol

smithy-lang · Jun 13, 2024 · 66e6279 · 66e6279
1 parent 2ae801a
commit 66e6279
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/main/java/software/amazon/smithy/lsp/SmithyLanguageServer.java b/src/main/java/software/amazon/smithy/lsp/SmithyLanguageServer.java
@@ -637,6 +637,10 @@ public CompletableFuture<CompletionItem> resolveCompletionItem(CompletionItem un
                         break;
                 }
                 String symbolName = documentShape.shapeName().toString();
+                if (symbolName.isEmpty()) {
+                    LOGGER.warning("[DocumentSymbols] Empty shape name for " + documentShape);
+                    continue;
+                }
                 Range symbolRange = documentShape.range();
                 DocumentSymbol symbol = new DocumentSymbol(symbolName, symbolKind, symbolRange, symbolRange);
                 documentSymbols.add(Either.forRight(symbol));

diff --git a/src/main/java/software/amazon/smithy/lsp/document/DocumentShape.java b/src/main/java/software/amazon/smithy/lsp/document/DocumentShape.java
@@ -65,6 +65,16 @@ public int hashCode() {
         return Objects.hash(range, shapeName, kind);
     }
 
+    @Override
+    public String toString() {
+        return "DocumentShape{" +
+               "range=" + range +
+               ", shapeName=" + shapeName +
+               ", kind=" + kind +
+               ", targetReference=" + targetReference +
+               '}';
+    }
+
     public enum Kind {
         DefinedShape,
         DefinedMember,