Add manuscript edition to the bibliographic meta data #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken from `mods:edition`, put into `tei:biblFull/editionStmt`.
kba
reviewed
Jul 23, 2019
| @@ -280,6 +289,12 @@ def get_publishers(self): | |||
| """ | |||
| return self.publishers | |||
|
|
|||
| def get_edition(self): | |||
There was a problem hiding this comment.
What's the advantage of self.get_edition() over self.edition?
I think we had that discussion before though but I forgot your reasoning.
There was a problem hiding this comment.
It's basically a left-over from C++ times. Obviously, getter/setter are not recommended (http://dirtsimple.org/2004/12/python-is-not-java.html) in Python. #21
kba
approved these changes
Jul 23, 2019
| """ | ||
| Adds an edition statement with details on the source manuscript. | ||
| """ | ||
| bibl_full = self.tree.xpath('//tei:fileDesc/tei:sourceDesc/tei:biblFull', namespaces=ns)[0] |
There was a problem hiding this comment.
Will that xpath always return results? If not, an error with that xpath might be more intuitive than an IndexError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from
mods:edition, put intotei:biblFull/editionStmt.