Merge pull request #40 from beatrycze-volk/fix-bool

[BUGFIX] Fix setting valus for `Access` objects
slub · Oct 8, 2024 · 53482b9 · 53482b9
2 parents 614efdf + 5f6e8d3
commit 53482b9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/Classes/Command/KitodoAccessGrantedNotification.php b/Classes/Command/KitodoAccessGrantedNotification.php
@@ -108,7 +108,7 @@ protected function updateAccessEntry(Access $accessEntry, $notificationTimestamp
     {
         // update access entry with notification time
         $accessEntry->setAccessGrantedNotification($notificationTimestamp);
-        $accessEntry->setInformUser(0);
+        $accessEntry->setInformUser(false);
         $this->AccessRepository->update($accessEntry);
     }
 

diff --git a/Classes/Controller/AccessController.php b/Classes/Controller/AccessController.php
@@ -172,7 +172,7 @@ public function informUserAction(User $user)
         /** @var Access $documentAccess */
         foreach ($user->getKitodoDocumentAccess() as $documentAccess) {
             if (!$documentAccess->getInformUser()) {
-                $documentAccess->setInformUser(1);
+                $documentAccess->setInformUser(true);
                 $this->accessRepository->update($documentAccess);
             }
         }
@@ -402,13 +402,13 @@ public function rejectAction(Access $access, User $user)
              return;
         }
 
-        $access->setHidden(1);
-        $access->setRejected(1);
+        $access->setHidden(true);
+        $access->setRejected(true);
         $access->setStartTime(0);
         $access->setEndTime(0);
         $access->setExpireNotification(0);
         $access->setAccessGrantedNotification(0);
-        $access->setInformUser(0);
+        $access->setInformUser(false);
 
         if ($access->getRejectedReason()) {
             $rejectedReason = strip_tags($access->getRejectedReason());

diff --git a/Classes/Controller/BasketController.php b/Classes/Controller/BasketController.php
@@ -224,11 +224,11 @@ public function requestAction()
                 foreach ($this->documents['rejectedDocumentRequests'] as $accessRejectedNewRequest) {
                     $accessRejectedNewRequest->setExpireNotification(0);
                     $accessRejectedNewRequest->setAccessGrantedNotification(0);
-                    $accessRejectedNewRequest->setRejected(0);
-                    $accessRejectedNewRequest->setHidden(1);
+                    $accessRejectedNewRequest->setRejected(false);
+                    $accessRejectedNewRequest->setHidden(true);
                     $accessRejectedNewRequest->setStartTime(0);
                     $accessRejectedNewRequest->setEndTime(0);
-                    $accessRejectedNewRequest->setInformUser(0);
+                    $accessRejectedNewRequest->setInformUser(false);
                     $this->accessRepository->update($accessRejectedNewRequest);
                     $documents[] = $accessRejectedNewRequest;
                 }