Avoid atty and bump MSRV to 1.63 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to newer `is-terminal` crate instead. This functionality is also availible on the nightly Rust stdlib as a `std::io::IsTerminal` trait. Avoids RUSTSEC-2021-0145 (softprops/atty#50) Fixes slog-rs/slog#319 Based on the information in the vulnerability database, I don't consider this a particularly serious bug. > In practice however, the pointer won't be unaligned unless a custom global allocator is used.
|
@Techcable , any plans for a 2.10.0 with this fix in? |
@Techcable any update on this? |
|
@dpc Hi, I see you're also listed together with @Techcable as owners. Might either of you please be able to release a new version with this PR integrated so the security warnings can go away for the crates which depend on this? Thank you! ❤️ |
Techcable
added a commit
to Techcable/slog-term
that referenced
this pull request
Feb 18, 2024
Includes important fix slog-rs#47 Sorry for the long wait!
|
Hi @rkd-msw , @mattledden , @Keavon -- I've released a new version I was hoping to include PR #44 , but I realized this was important to get out first. Please let me know if you need anything else :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #45 with an extra commit bumping the MSRV. I think this is necessary to match is_terminal's MSRV - https://github.com/sunfishcode/is-terminal/blob/main/Cargo.toml#L16.
CI passes on my fork: https://github.com/rkd-msw/term/actions/runs/5714633882