Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix var bytes calculation to support list variables which span transaction size #1017

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

slacrherbst
Copy link
Contributor

This fixes how varBytes is calculated for list varibles. This change is neccessary to support list variables where the first entry of a list is beyond the min transaction size.

This does require that all entries added to a listVariable (block of memory) use the same offset value and use the bitOffset to define the location of each value in the block of memory.

@slacrherbst slacrherbst changed the base branch from main to pre-release July 31, 2024 16:51
@bengineerd bengineerd merged commit a3d3818 into pre-release Aug 28, 2024
5 checks passed
@ruck314 ruck314 deleted the block_alignment branch September 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants