FIX: Properly manages Axes in the Archive Viewer #1094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksharsarvesh
force-pushed
the
axes
branch
5 times, most recently
from
2fae96c
to
c0a4ddb
Compare
|
Temporarily taken down because of a found bug |
|
Bugs in tests due to changes I made - removing from set of viewboxes is an issue? Will fix on Monday |
aksharsarvesh
force-pushed
the
axes
branch
16 times, most recently
from
7574cb8
to
845450e
Compare
|
Don't merge this until after #1095, but this is ready for review. I had this PR rely on Formulas because I wanted to make sure axes changes worked for formulas as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1095
Requires the pydm PR to go through, but allows the user to cleanly navigate adding, removing, and hiding axes; as well as hiding/removing curves and it properly hiding their axes. Finally, it defaults new curves to the correct axes upon creation and allows for easy switching between axes.