Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add new PCASpy server for running the tutorial. #1032

Merged
merged 21 commits into from
Oct 9, 2023

Conversation

nstelter-slac
Copy link
Collaborator

@nstelter-slac nstelter-slac commented Sep 14, 2023

Server mimics simulated motor and camera PV's.
Also brings over tutorial files to this main repo.

This allows us to drop the existing tutorial VM.

to run tutorial:
export EPICS_CA_MAX_ARRAY_BYTES=10000000
./examples/testing_ioc/pydm-tutorial-ioc
in another terminal...
export EPICS_CA_MAX_ARRAY_BYTES=10000000
pydm examples/tutorial/main.ui

@nstelter-slac nstelter-slac marked this pull request as ready for review October 5, 2023 05:44
Copy link
Collaborator

@jbellister-slac jbellister-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this! Stepped through the guide and everything is still working well, just some very minor things below

examples/testing_ioc/pydm-tutorial-ioc Outdated Show resolved Hide resolved
examples/testing_ioc/pydm-tutorial-ioc Outdated Show resolved Hide resolved
docs/source/tutorials/intro.rst Outdated Show resolved Hide resolved
docs/source/tutorials/intro.rst Outdated Show resolved Hide resolved
docs/source/widgets/PyDMWidget.rst Outdated Show resolved Hide resolved
docs/source/widgets/archiver_timeplot.rst Show resolved Hide resolved
docs/source/widgets/index.rst Show resolved Hide resolved
@nstelter-slac
Copy link
Collaborator Author

applied suggestions, thanks for the review!

Copy link
Collaborator

@jbellister-slac jbellister-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbellister-slac jbellister-slac merged commit 43da39e into slaclab:master Oct 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants