Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable super_read_only during PRS for v15->v19 migration #535

Open
wants to merge 3 commits into
base: slack-19.0
Choose a base branch
from

Conversation

tanjinx
Copy link

@tanjinx tanjinx commented Oct 14, 2024

In v19, PRS set the old primary super_read_only unconditionally during the demotion process. If we downgrade that tablet to v15, restart will fail with the error:

I1014 11:21:28.334578  336986 metadata_tables.go:82] Populating _vt.local_metadata table...
F1014 11:21:28.335299  336986 tm_init.go:775] RestoreFromBackup failed: The MySQL server is running with the --super-read-only option so it cannot execute this statement (errno 1290) (sqlstate HY000) during query: CREATE DATABASE IF NOT EXISTS _vt

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@github-actions github-actions bot added this to the v19.0.5 milestone Oct 14, 2024
@tanjinx tanjinx changed the title Add use_super_read_only back for v15->v19 migration Disable super_read_only during PRS for v15->v19 migration Oct 14, 2024
@tanjinx tanjinx marked this pull request as ready for review October 14, 2024 23:48
@tanjinx tanjinx requested a review from a team as a code owner October 14, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant