Added test for the missing ::Async::Reactor.run.

slack-ruby · Jul 26, 2023 · 76c1301 · 76c1301
1 parent 0720377
commit 76c1301
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/lib/slack-ruby-bot-server/service.rb b/lib/slack-ruby-bot-server/service.rb
@@ -78,8 +78,8 @@ def start_from_database!
       start_intervals!
     end
 
-    def start_intervals!
-      ::Async::Reactor.run do
+    def start_intervals!(&_block)
+      ::Async::Reactor.run do |task|
         @intervals.each_pair do |period, calls_with_options|
           calls_with_options.each do |call_with_options|
             call, options = *call_with_options
@@ -88,6 +88,7 @@ def start_intervals!
             end
           end
         end
+        yield task if block_given?
       end
     end
 

diff --git a/spec/slack-ruby-bot-server/service_spec.rb b/spec/slack-ruby-bot-server/service_spec.rb
@@ -56,8 +56,7 @@
     let(:instance) { SlackRubyBotServer::Service.instance }
     context 'without timers' do
       it 'noop' do
-        Async::Reactor.run do |task|
-          instance.start_intervals!
+        instance.start_intervals! do |task|
           task.stop
         end
         expect(instance.instance_variable_get(:@intervals).keys).to eq []
@@ -94,8 +93,7 @@
         end
       end
       it 'sets up timers' do
-        Async::Reactor.run do |task|
-          instance.start_intervals!
+        instance.start_intervals! do |task|
           task.sleep 3
           task.stop
         end
@@ -115,8 +113,7 @@
         end
       end
       it 'does not abort all timers on failure of the first one' do
-        Async::Reactor.run do |task|
-          instance.start_intervals!
+        instance.start_intervals! do |task|
           task.sleep 3
           task.stop
         end
@@ -132,8 +129,7 @@
           end
         end
         it 'runs the timer once within 3 seconds' do
-          Async::Reactor.run do |task|
-            instance.start_intervals!
+          instance.start_intervals! do |task|
             task.sleep 3
             task.stop
           end
@@ -148,8 +144,7 @@
           end
         end
         it 'runs the timer exactly twice within 3 seconds' do
-          Async::Reactor.run do |task|
-            instance.start_intervals!
+          instance.start_intervals! do |task|
             task.sleep 3
             task.stop
           end