Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Model and Database Update #181

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cmhhelgeson
Copy link

  1. Encapsulate the stats ui into its UI Layout/XML file. Although this introduces additional nesting layouts, it facilitates additional re-use of the stats ui across other parts of the application, such as if developers want to add a feature to compare stats amongst multiple Pokemon, or compare an individual Pokemon's stats as it levels up.

  2. Implement the PokeAPI's stats field into the relevant core-model and core-database files to facilitate pulling from those stats dynamically rather than randomly generating a Pokemon's stats when the application is loaded.

As of yet, these are just some the fundamental changes needed to prepare the application for actually implementing new stats related features. Accordingly, this pull request does not yet implement proper data binding for the new stats fields.

…tats layout into its own xml file to make the implementation of comparing two pokemon's attributes easier in a future pull request. 2. Implement the pokeapi's stats field into the relevant core-model and core-database files to facilitate pulling from those stats rather than randomly generating stats for each Pokemon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant