Remove unnecessary (?) compiler dependency #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can't remember why it was there but I agree, doesn't seem to be needed. |
|
Awesome, thanks. I wrote this PR in a bit of a rush so went back and found the commit where it was added. Seems like it was for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up with
protobuf-java3.7.0 on my project classpath, and found that the culprit wasavro4s-core -> scala3-compiler_3 -> compiler-interface. The problem is thatprotobuf-java3.7.0is very old and has a number of CVEs.At any rate, I was confused as to why avro4s needed the
scala3-compiler_3dependency, so tried compiling without it. It compiles fine, and tests pass.I assume it was added for a reason, at some point, but maybe is no longer necessary? Or am I missing something?