Gafetinov/upgrade for diadoc #39
Conversation
gafetinov
force-pushed
the
gafetinov/upgrade-for-diadoc
branch
from
0dd399e
to
eeed1ce
Compare
Cassandra.DistributedTaskQueue/Configuration/RtqTaskDataRegistryBase.cs
Outdated
Show resolved
Hide resolved
Cassandra.DistributedTaskQueue/Configuration/RtqTaskDataRegistryBase.cs
Outdated
Show resolved
Hide resolved
cassandra-distributed-task-queue-ui/src/components/TaskTable/TaskDetails/TaskDetails.tsx
Show resolved
Hide resolved
gafetinov
force-pushed
the
gafetinov/upgrade-for-diadoc
branch
from
6ca9ffd
to
4c7504b
Compare
Cassandra.DistributedTaskQueue/Cassandra/Entities/TaskMetaInformation.cs
Outdated
Show resolved
Hide resolved
gafetinov
force-pushed
the
gafetinov/upgrade-for-diadoc
branch
from
19a55df
to
a6456eb
Compare
|
|
||
| const CustomSettingsContext = createContext<ICustomSettings>(defaultValue); | ||
|
|
||
| export const CustomSettingsProvider = ({ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
его и таскать везде проще, он уже много где прокинут, не нужен будет новый контекст
There was a problem hiding this comment.
Не захотелось их в один класс потому что это независящие друг от друга штуки.
И в edi они не нужны, если их в класс положить, то придется все равно в edi прописывать эти методы после обновления. А так можно просто обновиться и не париться.
А по поводу контекста, хотелось убрать лишние прокидывания пропсов
There was a problem hiding this comment.
независящие, но они в целом про одно и то же: кастомизацию для ui очереди задач
There was a problem hiding this comment.
в целом и так сойдет конечно
| const executionTime = ticksToMilliseconds(executionDurationTicks); | ||
| console.log(executionTime); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| renderRow("ExpirationModificationTime", expirationModificationTicks, renderDate), | ||
| renderRow("LastModificationTime", lastModificationTicks, renderDate), | ||
| renderRow("Attempts", attempts.toString()), | ||
| renderRow("ParentTaskId", parentTaskId, parentTaskId => ( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| }; | ||
|
|
||
| const handleCheckAll = () => { | ||
| if (isAllTasksChosen) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
для галочки "Выбрать все на странице"
cassandra-distributed-task-queue-ui/src/components/TaskStatesSelect/TaskStatesSelect.tsx
Outdated
Show resolved
Hide resolved
cassandra-distributed-task-queue-ui/src/components/TaskTable/TaskDetails/TaskDetails.styles.ts
Show resolved
Hide resolved
| <tr key={"ParentTaskId"}> | ||
| <td>{"ParentTaskId"}</td> | ||
| <td data-tid={"ParentTaskId"}> | ||
| <RouterLink to={`../${parentTaskId}`}>{parentTaskId}</RouterLink> |
There was a problem hiding this comment.
тут если parentTaskId == null, то не надо рендерить же <RouterLink, раньше так было
Апгрейд для Диадока: