Semke/update back arrows #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafetinov
reviewed
Jun 28, 2023
| @@ -1,4 +1,4 @@ | |||
| import CopyIcon from "@skbkontur/react-icons/Copy"; | |||
| import { CopyIcon16Regular } from "@skbkontur/icons"; | |||
There was a problem hiding this comment.
Кокретизируй пути, а то все иконки будут тянутся вместе с этим пакетом
There was a problem hiding this comment.
Да согласен, я до этого поискал по чату инфры саппорта, и они говорили, что проблема с tree-shaking решена в этом пакете, даже проверил с помощью webpack-bundle-analyzer что все иконки не тянутся, но сейчас заметил, что в 1.x,x версиях опять эта проблема проявилась.
| backLink(): string { | ||
| return css` | ||
| position: absolute; | ||
| left: 2px; |
There was a problem hiding this comment.
Тоже самое про позиционирование либо через padding либо через left
semkedaniil
force-pushed
the
semke/update-back-arrows
branch
from
070f89e
to
951f496
Compare
|
@gafetinov, я поправил |
|
@semkedaniil, посмотрел - всё ок |
semkedaniil
force-pushed
the
semke/update-back-arrows
branch
from
0b29d45
to
3a5cc75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Заменил все стрелки "назад" на новые согласно фирстилю, также добавил заменил старые иконки на новые.