Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete invalid URIs #17

Merged
merged 2 commits into from
Nov 21, 2023
Merged

delete invalid URIs #17

merged 2 commits into from
Nov 21, 2023

Conversation

wasadus
Copy link
Contributor

@wasadus wasadus commented Nov 21, 2023

Excel can form hyperlink on inserting something resembling link, even if it is invalid. For example, after inserting "[email protected]>" (common mistake when someone copy address from email service), it will add link "mailto:[email protected]>". OpenXml will try to convert links to Uri on opening document and fail with exception. I propose deleting invalid links on opening document and leaving just plain text.

Ярин Захар Владимирович added 2 commits November 21, 2023 12:11
@wasadus
Copy link
Contributor Author

wasadus commented Nov 21, 2023

Turns out it was fixed in OpenXml, just changed version

@Dm17r1y Dm17r1y self-requested a review November 21, 2023 11:50
@wasadus wasadus merged commit 17021e6 into master Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants