Skip to content

Commit

Permalink
Merge pull request #21 from xificurk/v2.1
Browse files Browse the repository at this point in the history
v2.1
  • Loading branch information
xificurk authored Apr 19, 2018
2 parents 0a4faca + 2ef950a commit 2f5de54
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 32 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ Rozšíření pro [Nette](https://github.com/nette/nette) integrující [PHP kni

# Požadavky

[Nette Framework](https://github.com/nette/nette) verze 2.1 nebo vyšší. Detaily v [composer.json](./composer.json).
[Nette Framework](https://github.com/nette/nette) verze 2.4 nebo vyšší. Detaily v [composer.json](./composer.json).


# Instalace

Nainstalujte balíček přes composer ``composer require skautis/nette:2.0.*``, zaregistrujte a nastavte rozšíření (extension) v konfiguračním souboru.
Nainstalujte balíček přes composer ``composer require skautis/nette:^2.1``, zaregistrujte a nastavte rozšíření (extension) v konfiguračním souboru.

Ukázka minimální konfigurace:
```
Expand Down
3 changes: 1 addition & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
},
"require-dev": {
"nette/tester": "~1.3",
"nette/nette": "^2.4@dev",
"nette/utils": "^2.4@dev"
"nette/nette": "^2.4@dev"
},
"suggest": {
"tracy/tracy": "to enable skautis panel for Tracy debug bar.",
Expand Down
2 changes: 1 addition & 1 deletion docs/konfigurace.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Pomocí volby `compression: FALSE` je možné vypnout kompresi při provádění

## Profiler

Pokud máte nainstalovánou [Tracy](https://github.com/nette/tracy), nebo používáte Nette verze 2.1, tak se v testovacím modu Nette automaticky aktivuje skautis panel, který sleduje všechny dotazy na skautis.
Pokud máte nainstalovánou [Tracy](https://github.com/nette/tracy), tak se v testovacím modu Nette automaticky aktivuje skautis panel, který sleduje všechny dotazy na skautis.

![Skautis panel pro ladění aplikace](skautis-panel.png)

Expand Down
12 changes: 4 additions & 8 deletions src/CacheAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@
use Skautis\Wsdl\Decorator\Cache\CacheInterface;


if (!class_exists('Nette\Utils\DateTime') && class_exists('Nette\DateTime')) {
// BC with Nette 2.1
class_alias('Nette\DateTime', 'Nette\Utils\DateTime');
}


/**
* Nette cache adapter for Skautis library
*/
class CacheAdapter implements CacheInterface
{

use Nette\SmartObject;

/** @var IStorage */
private $storage;

Expand Down Expand Up @@ -101,7 +97,7 @@ public function set($key, $data)
*/
private function getDependencies()
{
$dependencies = array();
$dependencies = [];

if (isset($this->expiration)) {
$dependencies[Cache::EXPIRATION] = Nette\Utils\DateTime::from($this->expiration)->format('U') - time();
Expand All @@ -128,7 +124,7 @@ protected function generateKey($key)
*/
public function clean()
{
$this->storage->clean(array(Cache::ALL => TRUE));
$this->storage->clean([Cache::ALL => TRUE]);
}

}
2 changes: 2 additions & 0 deletions src/SessionAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
class SessionAdapter implements AdapterInterface
{

use Nette\SmartObject;

/** @var Nette\Http\SessionSection */
protected $sessionSection;

Expand Down
5 changes: 2 additions & 3 deletions src/SkautisExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Skautis\Nette;

use Nette;
use Nette\DI\Config;
use Skautis;
use Tracy\Debugger;

Expand Down Expand Up @@ -34,7 +33,7 @@ public function loadConfiguration()
$config['profiler'] = isset($config['profiler']) ? $config['profiler'] : !empty($container->parameters['debugMode']);

$container->addDefinition($this->prefix('config'))
->setClass(Skautis\Config::class, array($config['applicationId'], $config['testMode'], $config['cache'], $config['compression']));
->setClass(Skautis\Config::class, [$config['applicationId'], $config['testMode'], $config['cache'], $config['compression']]);

$container->addDefinition($this->prefix('webServiceFactory'))
->setClass(Skautis\Wsdl\WebServiceFactory::class);
Expand All @@ -54,7 +53,7 @@ public function loadConfiguration()
if ($config['profiler'] && class_exists(Debugger::class)) {
$panel = $container->addDefinition($this->prefix('panel'))
->setClass(Skautis\Nette\Tracy\Panel::class);
$manager->addSetup([$panel, 'register'], array($manager));
$manager->addSetup([$panel, 'register'], [$manager]);
}
}

Expand Down
26 changes: 10 additions & 16 deletions src/Tracy/Panel.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@
*/
class Panel implements Tracy\IBarPanel
{
use Nette\SmartObject;

/** @var string */
private $htmlPrefix = 'tracy';
use Nette\SmartObject;

/** @var array */
private $queries = array();
private $queries = [];


/**
Expand All @@ -31,8 +29,8 @@ class Panel implements Tracy\IBarPanel
*/
public function register(WsdlManager $wsdlManager)
{
$wsdlManager->addWebServiceListener(WebService::EVENT_SUCCESS, array($this, 'logEvent'));
$wsdlManager->addWebServiceListener(WebService::EVENT_FAILURE, array($this, 'logEvent'));
$wsdlManager->addWebServiceListener(WebService::EVENT_SUCCESS, [$this, 'logEvent']);
$wsdlManager->addWebServiceListener(WebService::EVENT_FAILURE, [$this, 'logEvent']);
Tracy\Debugger::getBar()->addPanel($this);
}

Expand Down Expand Up @@ -73,19 +71,19 @@ public function getPanel()
$cnt = 0;
$s = "";
foreach ($this->queries as $query) {
$rowId = "{$this->htmlPrefix}-debug-Skautis-args-row-$cnt";
$rowId = "tracy-debug-Skautis-args-row-$cnt";
$s .= "<tr>"
. "<td>" . sprintf('%0.2f', $query->time * 1000) . "</td>"
. "<td>{$query->fname}(" . $this->formatToggle('Args', $rowId) . ")<div id='$rowId' class='{$this->htmlPrefix}-collapsed'>" . $this->dump(reset($query->args[0])) . "</div></td>"
. "<td>" . $this->formatToggle('Result'). "<div class='{$this->htmlPrefix}-collapsed'>" . $this->dump($query->result) . "</div></td>"
. "<td>{$query->fname}(" . $this->formatToggle('Args', $rowId) . ")<div id='$rowId' class='tracy-collapsed'>" . $this->dump(reset($query->args[0])) . "</div></td>"
. "<td>" . $this->formatToggle('Result'). "<div class='tracy-collapsed'>" . $this->dump($query->result) . "</div></td>"
. "<td>" . $this->prepareTrace($query->trace) . "</td>"
. "</tr>";
$cnt++;
}

return empty($this->queries) ? '' :
'<h1>Skautis</h1>'
. '<div class="' . $this->htmlPrefix . '-inner">'
. '<div class="tracy-inner">'
. '<table>'
. '<tr><th>Time&nbsp;ms</th><th>Function&nbsp;name</th><th>Result</th><th>Trace</th></tr>'
. $s
Expand All @@ -105,7 +103,7 @@ protected function prepareTrace(array $trace)
foreach ($trace as $f) {
$s .= "" . ++$cnt . ". " . $f['function'] . " (" . (array_key_exists("class", $f) ? ":" . $f['class'] : "") . (array_key_exists("line", $f) ? ":" . $f['line'] : "") . ")" . '<br>';
}
return $this->formatToggle('Trace') . "<div class='{$this->htmlPrefix}-collapsed'>" . $s . "</div>";
return $this->formatToggle('Trace') . "<div class='tracy-collapsed'>" . $s . "</div>";
}


Expand All @@ -126,11 +124,7 @@ protected function dump($object)
*/
protected function formatToggle($name, $rel = NULL)
{
// BC with Nette 2.1
$toggleClass = $this->htmlPrefix === 'tracy'
? "{$this->htmlPrefix}-toggle {$this->htmlPrefix}-collapsed"
: "{$this->htmlPrefix}-toggler {$this->htmlPrefix}-toggle-collapsed";
return "<a href='#" . ($rel === NULL ? "" : "$rel' rel='#$rel") . "' class='$toggleClass'>$name</a>";
return "<a href='#" . ($rel === NULL ? "" : "$rel' rel='#$rel") . "' class='tracy-toggle tracy-collapsed'>$name</a>";
}

}

0 comments on commit 2f5de54

Please sign in to comment.