Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Hospital Name instead of ID #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show Hospital Name instead of ID #43

wants to merge 1 commit into from

Conversation

Hjaelp
Copy link
Contributor

@Hjaelp Hjaelp commented Feb 17, 2021

Closes #32

siv2r
siv2r reviewed Feb 18, 2021
View reviewed changes
Copy link
Owner

@siv2r siv2r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem correct!! Were you able to test it?

siv2r
siv2r reviewed Feb 18, 2021
View reviewed changes
Copy link
Owner

@siv2r siv2r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick tip. The conventional way would be to create a pull request from a new branch in your fork rather than from its master :)
I will try to add a contributor's guide mentioning these things soon.

@Hjaelp
Copy link
Contributor Author

Hjaelp commented Feb 19, 2021 •
edited
Loading

The changes seem correct!! Were you able to test it?

I did.

@siv2r
Copy link
Owner

siv2r commented Feb 20, 2021

Will merge it soon!! Thanks for the PR 🎉 🎉

@siv2r
Copy link
Owner

siv2r commented Mar 8, 2021

@Hjaelp, can you rebase and send the PR again?

@siv2r siv2r mentioned this pull request Mar 8, 2021
Open
@siv2r siv2r self-requested a review October 6, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siv2r siv2r siv2r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display hospital name instead of hospital id in the patient data
2 participants
@Hjaelp @siv2r