-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to Angular 17 #498
Conversation
I got this error after I use the ng17 branch in my package.json:
And here is my package.json: |
Why would you use the ng17 branch? |
@arturovt Because our project uses Angular17, but single-spa-angular has not yet released a version corresponding to Angular17, and I saw the commit you mentioned, so I want to try it with your ng17 branch. I would like to ask, is your commit about all the changes to upgrade to support angular17? |
The single-spa-angular is compatible with angular 17. |
OK, thanks |
@arturovt - Is there anything I can do to help bump this merge along? I'm sure you're super busy, but this has been open for a few months now and I figured it wouldn't hurt to merge it in before angular 18 rolls around 😄 |
I added this #499 to solve the build issues preventing this PR from being buildable. |
@arturovt I see that all changes about ng17 are inside the main branch. Is there a plan to relase npm version? |
No description provided.