Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Angular 17 #498

Merged
merged 1 commit into from
Jan 24, 2024
Merged

feat: upgrade to Angular 17 #498

merged 1 commit into from
Jan 24, 2024

Conversation

arturovt
Copy link
Member

No description provided.

@Wushurui
Copy link

I got this error after I use the ng17 branch in my package.json:
An unhandled exception occurred: Cannot find module 'single-spa-angular/libs/single-spa-angular/webpack'
Require stack:

  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/extra-webpack.config.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular-builders/custom-webpack/dist/utils.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular-builders/custom-webpack/dist/custom-webpack-builder.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular-builders/custom-webpack/dist/transform-factories.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular-builders/custom-webpack/dist/generic-browser-builder.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular-builders/custom-webpack/dist/dev-server/index.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular-devkit/architect/node/node-modules-architect-host.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular-devkit/architect/node/index.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular/cli/src/command-builder/architect-base-command-module.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular/cli/src/command-builder/architect-command-module.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular/cli/src/commands/serve/cli.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular/cli/src/commands/command-config.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular/cli/src/command-builder/command-runner.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular/cli/lib/cli/index.js
  • /Users/alexawu/Documents/upgrade-projects/hk-aws-agt-rpt-admin-sws/node_modules/@angular/cli/lib/init.js
    See "/private/var/folders/hz/c6mk40394n57p3y5090264w83xhtk8/T/ng-KCoLJA/angular-errors.log" for further details.

And here is my package.json:
"dependencies": {
"@angular-builders/custom-webpack": "^17.0.0",
"@angular/animations": "^17.0.8",
"@angular/cdk": "^17.0.4",
"@angular/common": "^17.0.8",
"@angular/compiler": "^17.0.8",
"@angular/core": "^17.0.8",
"@angular/forms": "^17.0.8",
"@angular/platform-browser": "^17.0.8",
"@angular/platform-browser-dynamic": "^17.0.8",
"@angular/router": "^17.0.8",
"@manulife-design/md": "^1.0.5",
"file-saver": "^2.0.5",
"numeral": "^2.0.6",
"powerbi-client-angular": "^3.0.5",
"rxjs": "~7.8.1",
"single-spa": "^5.9.5",
"single-spa-angular": "github:single-spa/single-spa-angular#ng17",
"tslib": "^2.1.0",
"xlsx": "^0.18.5",
"zone.js": "^0.14.2"
},
"devDependencies": {
"@angular-devkit/build-angular": "^17.0.8",
"@angular/cli": "^17.0.8",
"@angular/compiler-cli": "^17.0.8",
"@angular/language-service": "^17.0.8",
"@types/file-saver": "^2.0.4",
"@types/jasmine": "^4.3.5",
"@types/jasminewd2": "~2.0.10",
"@types/node": "~16.11.7",
"codelyzer": "^6.0.2",
"jasmine-core": "~4.6.0",
"jasmine-spec-reporter": "~7.0.0",
"karma": "~6.4.2",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage-istanbul-reporter": "~3.0.3",
"karma-jasmine": "^5.1.0",
"karma-jasmine-html-reporter": "^2.0.0",
"protractor": "~7.0.0",
"sonar-scanner": "^3.1.0",
"systemjs-webpack-interop": "^2.3.7",
"ts-node": "~10.9.1",
"tslint": "~6.1.3",
"typescript": "^5.2.2",
"webpack": "^5.88.2"
}

@arturovt
Copy link
Member Author

Why would you use the ng17 branch?

@Wushurui
Copy link

Wushurui commented Dec 29, 2023

@arturovt Because our project uses Angular17, but single-spa-angular has not yet released a version corresponding to Angular17, and I saw the commit you mentioned, so I want to try it with your ng17 branch. I would like to ask, is your commit about all the changes to upgrade to support angular17?

@arturovt
Copy link
Member Author

The single-spa-angular is compatible with angular 17.

@Wushurui
Copy link

Wushurui commented Jan 2, 2024

OK, thanks

@b-ferrari
Copy link

@arturovt - Is there anything I can do to help bump this merge along? I'm sure you're super busy, but this has been open for a few months now and I figured it wouldn't hurt to merge it in before angular 18 rolls around 😄

@victorlevasseur
Copy link
Contributor

I added this #499 to solve the build issues preventing this PR from being buildable.
Meanwhile, when our teams began migrating to Angular 17, we encountered issues with parcels and zone.js when navigating from/to microfrontends using Angular 17 (but the parcels are still Angular 14).
I'll try to have an small example to try to replicate the issue.

@arturovt arturovt marked this pull request as ready for review January 24, 2024 19:21
@arturovt arturovt merged commit 59b85bd into master Jan 24, 2024
1 check passed
@arturovt arturovt deleted the ng17 branch January 24, 2024 19:21
@roshaw
Copy link

roshaw commented Feb 28, 2024

@arturovt I see that all changes about ng17 are inside the main branch. Is there a plan to relase npm version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants