Skip to content

Commit

Permalink
Tdl 25029 fix pk chunking condition (#176)
Browse files Browse the repository at this point in the history
* updated pk chunk condition
* updated setup and changelog
* added EventLogFile stream to exception
---------

Co-authored-by: Bryant Gray <[email protected]>
  • Loading branch information
Vi6hal and bryantgray authored Mar 12, 2024
1 parent e27ff3b commit a217508
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 2.0.1
* Fix `_can_pk_chunk_job` condition, details: [#176](https://github.com/singer-io/tap-salesforce/pull/176)

## 2.0.0
* Fix the LightningUriEvent stream primary key [#163](https://github.com/singer-io/tap-salesforce/pull/163)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup

setup(name='tap-salesforce',
version='2.0.0',
version='2.0.1',
description='Singer.io tap for extracting data from the Salesforce API',
author='Stitch',
url='https://singer.io',
Expand Down
6 changes: 3 additions & 3 deletions tap_salesforce/salesforce/bulk.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ def _get_bulk_headers(self):
"Content-Type": "application/json"}

def _can_pk_chunk_job(self, failure_message):
return "QUERY_TIMEOUT" in failure_message or \
"Retried more than 15 times" in failure_message or \
"Failed to write query result" in failure_message
return "QUERY_TIMEOUT" in failure_message or \
"Retried more" in failure_message or \
"Failed to write query result" in failure_message

def _bulk_query(self, catalog_entry, state):
job_id = self._create_job(catalog_entry)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_salesforce_switch_rep_method_ft_incrmntl.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def name():


def expected_sync_streams(self):
streams = self.switchable_streams() - {'FlowDefinitionView','EntityDefinition'}
streams = self.switchable_streams() - {'FlowDefinitionView','EntityDefinition', 'EventLogFile'}
# Excluded the above two streams due to the bug TDL-24514
return self.partition_streams(streams)

Expand Down

0 comments on commit a217508

Please sign in to comment.