Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tdl 25431/add region name in config #64

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tdl 25431/add region name in config #64

wants to merge 4 commits into from

Conversation

rdeshmukh15
Copy link

@rdeshmukh15 rdeshmukh15 commented Mar 21, 2024 •
edited
Loading

Description of change

  • When listing down the objects in the s3 bucket which is located in other than the default region (i.e. us-east-1), tap throws IllegalLocationConstraintException. And, to resolve this, we are passing region_name as a user configurable property while creating s3_client (TDL-25431)
  • Respective updates in README.md
  • Release related changes in setup.py and CHANGELOG.md

Manual QA steps

  • Executed the tap in discover and sync mode

Risks

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rdeshmukh15