TDL-20697: Move JSONL code base to singer-encodings #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: The build is failing because of pylint error as we have updated some functions on the singer-encodings side where we have added new arguments for some functions. |
hpatel41
changed the title
dbshah1212
reviewed
Oct 11, 2022
| @@ -3,19 +3,20 @@ | |||
| import singer | |||
There was a problem hiding this comment.
Update the singer-encoding version in the setup.py file.
dbshah1212
approved these changes
Oct 12, 2022
savan-chovatiya
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
JSONL code refactoring.
NOTE: This PR is dependent on singer-encodings PR #23. After releasing the new version for the singer-encodings library, we need to update the singer-encodings version in
setup.pyManual QA steps
Risks
Rollback steps