Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.2.0.0 Major revision to use updated Recharge API Version #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jeffhuth-paro
Copy link
Contributor

Description of change

Major revision to use new version of the Recharge-API 2021-11. This deprecates collections, adds payment_methods, changes shop endpoint to store, and adds/removes fields in all other objects. Also, added retry to client.py and decrease batch size to address intermittent unterminated string issue.

Manual QA steps

Tested all endpoints with singer-check-tap (singer-tools), replication to target-stitch (with and without previous state), and verified pylint code quality.

Risks

Major version release: adds 1 new endpoint, deprecates 1 endpoint, and adds/removes fields to all other endpoints. Recharge offers different client configurations which enables/disables some endpoints. Added a discovery/schema check to only allow available endpoints.

Rollback steps

Revert to previous version: v.1.1.2

Upgrade Recharge API version
Fix Discovery to verify endpoints work, new endpoints for payment_methods and collections, fix sync issue with unterminated string, update readme, pylint code quality changes
Update tests and changelog
@cmerrick
Copy link
Contributor

cmerrick commented Jan 7, 2022

Hi @jeffhuth-paro, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

cmerrick commented Jan 7, 2022

You did it @jeffhuth-paro!

Thank you for signing the Singer Contribution License Agreement.

@thehill383
Copy link

We are using Recharge and are increasingly finding that we are going to need to start using the 2021-11 version of their API.
i have just started exploring Singer, how would this work, would it be able to target the two different API versions independently?

@jeffhuth-paro
Copy link
Contributor Author

@thehill383 This would require a major version release on the Singer tap; which requires some work and approval from Stitch engineering. Once it is released, then clients would have to work with Stitch support to get the new version. They would need to drop their current schema in their DWH and re-load all history/data (because the table/fields are somewhat different).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants