Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the sync functionality so it lifts properties #87

Open
wants to merge 1 commit into
base: lift_properties
Choose a base branch
from
Open

Change the sync functionality so it lifts properties #87

wants to merge 1 commit into from

Conversation

b-ryan
Copy link

@b-ryan b-ryan commented Feb 22, 2019 •
edited
Loading

This updates the merge request in #80 so that it lifts the properties dictionary to the top level. The existing merge request only modified the schema generation.

Testing:

  • Generated a catalog and marked the companies stream for sync. Ran the sync and confirmed the records have data from properties
  • Changed the catalog to sync most other streams (left out ones that did too many requests) and confirmed the sync completed

mdimercurio pushed a commit to dialoguemd-archives/tap-hubspot that referenced this pull request Jun 1, 2019
@jacobfrackson
Migrate engineering performance dashboard to DBT (singer-io#87)
f787f4a 
* Migrate engineering performance dashboard to DBT

* Remove unnecessary coalesce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@b-ryan