Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres compatible tap-hubspot #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mirelagrigoras
Copy link

Tap-hubspot, as it is now, generates a schema with 2 types for integer fields, which is not allowed in a Postgres database (a column must have a single data type) and will make the postgres target (or any other relational databases targets) to generate 2 columns with different types and different names.
In this pull request I add a new argument that can be passed to the tap --postgres_compatible which will make the tap replace N/A values with None and generate a schema that will contain "type":[ "null", "number" ] for integer fields, not "type":[ "null", "number" , "string"], as it happens in the current version. Otherwise, if the --postgres_compatible argument is not passed, the schema that is generated will remain the same as it is at the moment.

This is an alternative to #85

mdimercurio added a commit to dialoguemd-archives/tap-hubspot that referenced this pull request Jun 1, 2019
@paddie
Copy link

paddie commented Jan 6, 2020

@mdimercurio thanks for this, I used it to solve the issue I had with the target-bigquery - which is also breaking on multiple types.

@VindiwW
Copy link

VindiwW commented Jan 10, 2021

@mdimercurio thanks for this, I used it to solve the issue I had with the target-bigquery - which is also breaking on multiple types.

Hi @paddie ,

I'm also trying to get data from tap-hubspot to target-bigquery, I modified my init.py file. Where should I implement the change @mirelagrigoras added to the commit?

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants