Update form sync to include all form types #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
By default, the forms API endpoint only returns "Hubspot" forms and not any of the other form types available in Hubspot. This can lead to missing data when using certain features in Hubspot Pages, cross-referencing with Hubspot Analytics, or integrating Hubspot with external site forms. To get the data about these forms, an additional option must be provided to the API endpoint to return all form types.
More information about the form types is available here: https://developers.hubspot.com/docs/api/marketing/forms
Manual QA steps
I ran the tap using this change and confirmed that it still worked successfully and the additional form types were now present in the forms data.
Risks
None
Rollback steps
Revert this branch