Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supportAllDrives parameter to also support shared drives #60

Closed
wants to merge 1 commit into from

Conversation

Somtom
Copy link

@Somtom Somtom commented Dec 15, 2021

Description of change

The tap currently does not support drives other than "My Drive" (e.g. #7) . We ran into this issue as well and found a stackoverflow post which actually points to the Google Documentation where the supportsAllDrives parameter is mentioned.

I added it to the request for the metadata (where the tap would fail) so that we now can also load sheets from shared drives

Manual QA steps

  • Put a file into a shared drive
  • Run the tap pointing to that file

Risks

  • Don't see any (expect) I am overseeing some side effects of the adjustment

Rollback steps

  • revert this branch

@coisnepe
Copy link

I'd love for this to be merged, as the inability of Stitch to handle shared Google files is blocking our move to subscribe… Thanks for the initiative !

@coisnepe
Copy link

coisnepe commented Jan 6, 2022

Any update on this? Have the maintainers taken a look?

@Somtom
Copy link
Author

Somtom commented Jan 6, 2022

@coisnepe did not hear anything yet. Maybe @leslievandemark can have a look? I saw you approved the last version bump

@drewipson
Copy link

Add a comment to encourage merging this branch into master as I ran into this same error and implemented a fix prior to finding this issue. Currently forked, but would love to have master support all drives.

@Somtom
Copy link
Author

Somtom commented Feb 1, 2022

Having another try to tag someone: @KrisPersonal I saw you did some version bumps recently as well. Maybe you can help us out here. I found it quite frustrating to contribute to this project if no one of the maintainers feels responsible to give feedback.

@aroder
Copy link

aroder commented Mar 8, 2022

Any updates to this? Seems like it could be a very useful tap. We are running into this issue and it is preventing us from using the tap

@aroder
Copy link

aroder commented Mar 10, 2022

@Somtom I added this change to #69 because the master branch has changed so much on this one. Thanks for discovering the fix for this, and hopefully we can get it merged

@reallocf
Copy link

We will definitely use this once it merges! Thanks @Somtom and @aroder for making the PRs!

@Somtom
Copy link
Author

Somtom commented Oct 1, 2022

Closing since it was added in a different PR

@Somtom Somtom closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants