Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for shared google drives #69

Closed
wants to merge 2 commits into from
Closed

add support for shared google drives #69

wants to merge 2 commits into from

Conversation

aroder
Copy link

@aroder aroder commented Mar 10, 2022

Description of change

When a google sheet is in a shared google drive, the tap fails. This requires a minor adjustment to parameters.

Resolves #7

This supersedes #60 , which has merge conflicts with the current main branch

Tagging @Somtom @jeffhuth-bytecode @fraser to hopefully get some eyes on this.

Manual QA steps

  • Connect to a sheet and verify the stream works
  • Move the sheet to a shared drive
  • Attempt connecting again and observe that it fails
  • Attempt connecting again with this code change in place and observe that it works

Risks

  • This is affecting many people who use the tap. Your only risk is ignoring the PR! Because people are having to fork or find alternate solutions.

Rollback steps

  • revert this branch

@aroder aroder mentioned this pull request Mar 10, 2022
Closed
@fraser
Copy link

fraser commented Mar 10, 2022

Hi @aroder , I think you pinged the wrong Fraser.

@aroder aroder marked this pull request as ready for review March 15, 2022 13:40
@aroder
Copy link
Author

aroder commented Mar 15, 2022

Yep, I should have pinged @frasermarlow. ☝️

@aroder
Copy link
Author

aroder commented Jun 21, 2022

@fraser @kspeer825 what do you think of this one? Can it be merged?

@morgzmatty
Copy link

morgzmatty commented Jul 8, 2022 •
edited
Loading

Thought that would work but guess not, also waiting on this to be merged!

@morgzmatty
Copy link

Would look into adding any of these users on this PR as reviewers: #85

@dmosorast
Copy link

@aroder @morgzmatty Thanks a bunch for keeping up on this! There's been a bit of a back-and-forth on how best to go about this (whether it needs to be an option or not), but it finally settled on the implementation you have here since it seems to work for any sheet (shared or not). Going to close this in favor of #89 for the automation run there as part of the wider effort on this tap.

Thanks again for raising this and doing the testing to build our confidence in the change!

@dmosorast dmosorast closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgzmatty morgzmatty morgzmatty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Sheet Integration failing with file not found
4 participants
@aroder @fraser @morgzmatty @dmosorast