Fixes link to spec 404 #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @auyer, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @auyer! Thank you for signing the Singer Contribution License Agreement. |
The previous link to the singer spec yielded a 404 error, because the file `SPEC.md` was moved to docs/SPEC.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous link to the singer spec yielded a 404 error, because the file
SPEC.mdwas moved todocs/SPEC.mdThere still is aSPEC.mdfile located in a sub folder (link to file).If that is the intended file, send a message in the PR and I'll make the change.
Update: I've checked different taps and decided that the second option (in the
strikedpart) was correct. I've commited the change and squashed both commits.Description of change
Link to spec in the docs was corrected
Manual QA steps
Risks
Rollback steps