Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding nullify_notifiable as option to dependent_notifications #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christopher-avila
Copy link

Issue #, if available:
#140

Summary

  1. Adding a new option to available_dependent_notifications_options called nullify_notifiable.
  2. Adding a new option to add_destroy_dependency for that key we defined before.
  3. Defining into the Notifiable module the new function which will update all the generated_notifications_as_notifiable_for(target_type) to notifiable_type and id to nil.

@simukappu
Copy link
Owner

simukappu commented Sep 27, 2020

Thank you for your contribution!
I think this requested feature is clear, but just wonder what its use cases are. Are there any use cases you would like to nullify notifiable, not deleting notifications?
And, I would appreciate it if you could write RSpec tests of this new :nullify_notifiable option.

Let's discuss in #140. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants