Raise coverage

simplesamlphp · Oct 7, 2024 · c86642c · c86642c
1 parent 2b628ca
commit c86642c
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 4 deletions.
diff --git a/src/XML/soap12/AbstractHeader.php b/src/XML/soap12/AbstractHeader.php
@@ -145,7 +145,7 @@ public static function fromXML(DOMElement $xml): static
      */
     public function toXML(DOMElement $parent = null): DOMElement
     {
-        $e = $this->instantiateParentElement($parent);
+        $e = parent::toXML($parent);
 
         $e->setAttribute('message', $this->getMessage());
         $e->setAttribute('parts', $this->getParts());

diff --git a/src/XML/soap12/AbstractOperation.php b/src/XML/soap12/AbstractOperation.php
@@ -142,8 +142,8 @@ public function toXML(DOMElement $parent = null): DOMElement
             $e->setAttribute('soapAction', $this->getSoapAction());
         }
 
-        if ($this->getSoapAction() !== null) {
-            $e->setAttribute('soapActionRequired', $this->getSoapAction() ? 'true' : 'false');
+        if ($this->getSoapActionRequired() !== null) {
+            $e->setAttribute('soapActionRequired', $this->getSoapActionRequired() ? 'true' : 'false');
         }
 
         if ($this->getStyle() !== null) {

diff --git a/tests/WSDL/XML/soap12/BindingTest.php b/tests/WSDL/XML/soap12/BindingTest.php
@@ -62,5 +62,7 @@ public function testMarshalling(): void
             self::$xmlRepresentation->saveXML(self::$xmlRepresentation->documentElement),
             strval($binding),
         );
+
+        $this->assertFalse($binding->isEmptyElement());
     }
 }
diff --git a/tests/WSDL/XML/soap12/BodyTest.php b/tests/WSDL/XML/soap12/BodyTest.php
@@ -64,5 +64,7 @@ public function testMarshalling(): void
             self::$xmlRepresentation->saveXML(self::$xmlRepresentation->documentElement),
             strval($body),
         );
+
+        $this->assertFalse($body->isEmptyElement());
     }
 }
diff --git a/tests/WSDL/XML/soap12/HeaderTest.php b/tests/WSDL/XML/soap12/HeaderTest.php
@@ -74,6 +74,7 @@ public function testMarshalling(): void
             [$headerFault],
             'urn:x-simplesamlphp:coding',
             'urn:x-simplesamlphp:namespace',
+            true,
         );
 
         $this->assertEquals(

diff --git a/tests/WSDL/XML/soap12/OperationTest.php b/tests/WSDL/XML/soap12/OperationTest.php
@@ -62,5 +62,7 @@ public function testMarshalling(): void
             self::$xmlRepresentation->saveXML(self::$xmlRepresentation->documentElement),
             strval($operation),
         );
+
+        $this->assertFalse($operation->isEmptyElement());
     }
 }
diff --git a/tests/resources/xml/soap12/Header.xml b/tests/resources/xml/soap12/Header.xml
@@ -1,3 +1,3 @@
-<soap12:header xmlns:soap12="http://schemas.xmlsoap.org/wsdl/soap12/" message="soap12:tOperation" parts="foo bar" use="literal" encodingStyle="urn:x-simplesamlphp:coding" namespace="urn:x-simplesamlphp:namespace">
+<soap12:header xmlns:soap12="http://schemas.xmlsoap.org/wsdl/soap12/" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" wsdl:required="true" message="soap12:tOperation" parts="foo bar" use="literal" encodingStyle="urn:x-simplesamlphp:coding" namespace="urn:x-simplesamlphp:namespace">
   <soap12:headerfault message="soap12:tOperation" parts="foo bar" use="literal" encodingStyle="urn:x-simplesamlphp:coding" namespace="urn:x-simplesamlphp:namespace"/>
 </soap12:header>