Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add brazilian portuguese language #42

Merged
merged 1 commit into from
May 20, 2024

Conversation

thedmmatt
Copy link
Contributor

@thedmmatt thedmmatt commented May 13, 2024

Pull request from ptocular branch to Ocular's main branch to provide Portuguese (Brazil) as a language option.

Both Contributing Guidelines and "turkish" pull request have been followed to the extent of all guidance provided, except by test:ci routine which did not respond to move build as a PR. Please advise if additional steps are required.

@thedmmatt thedmmatt requested a review from simonwep as a code owner May 13, 2024 23:44
@thedmmatt
Copy link
Contributor Author

thedmmatt commented May 14, 2024

@simonwep, I'm double-checking the pt-br.json file for any issues, but so far the CI / build routine yet throws an error from the ESLint rules, specifically at the file Draggable.vue which I'm still looking into.

The weird part is that GH suggests ln. 130 col. 7 as the culprit, but... it's just CSS styling. So, maybe reviewing the CI/CD pipeline or maybe skipping Vue's attr-orders altogether?

Edit 1: Debug just shows that the issue is an invalid character \", which it's not present in Draggable.vue (since I did not edit it), but of course, is present in pt-br.json to escape double quotes. It should still work, but I'll try removing them if the next CI workflow does not work.

Edit 2: Just fixed a syntax error in pt-br.json where page > header had a missing comma. If this is the culprit, GH was pointing to the wrong file and line.

@simonwep
Copy link
Owner

@simonwep, I'm double-checking the pt-br.json file for any issues, but so far the CI / build routine yet throws an error from the ESLint rules, specifically at the file Draggable.vue which I'm still looking into.

The weird part is that GH suggests ln. 130 col. 7 as the culprit, but... it's just CSS styling. So, maybe reviewing the CI/CD pipeline or maybe skipping Vue's attr-orders altogether?

Edit 1: Debug just shows that the issue is an invalid character \", which it's not present in Draggable.vue (since I did not edit it), but of course, is present in pt-br.json to escape double quotes. It should still work, but I'll try removing them if the next CI workflow does not work.

Edit 2: Just fixed a syntax error in pt-br.json where page > header had a missing comma. If this is the culprit, GH was pointing to the wrong file and line.

No worries :) I changed and force-pushed a few things, since I'm currently setting up contributing guidelines and tinkering what others need to successfully contribute:

  • There was a typo in your localization file, unknownError vs unkownError - yeah, the TS error message is pretty crappy.
  • Please use conventional commits, as already mentioned in the contributing guidelines.
  • I squashed all your commits since fixes usually don't need an extra commit.

In the coming days I'll merge this one, thank you so much for your contribution ❤️

@thedmmatt
Copy link
Contributor Author

@simonwep, I'm double-checking the pt-br.json file for any issues, but so far the CI / build routine yet throws an error from the ESLint rules, specifically at the file Draggable.vue which I'm still looking into.
The weird part is that GH suggests ln. 130 col. 7 as the culprit, but... it's just CSS styling. So, maybe reviewing the CI/CD pipeline or maybe skipping Vue's attr-orders altogether?
Edit 1: Debug just shows that the issue is an invalid character \", which it's not present in Draggable.vue (since I did not edit it), but of course, is present in pt-br.json to escape double quotes. It should still work, but I'll try removing them if the next CI workflow does not work.
Edit 2: Just fixed a syntax error in pt-br.json where page > header had a missing comma. If this is the culprit, GH was pointing to the wrong file and line.

No worries :) I changed and force-pushed a few things, since I'm currently setting up contributing guidelines and tinkering what others need to successfully contribute:

  • There was a typo in your localization file, unknownError vs unkownError - yeah, the TS error message is pretty crappy.
  • Please use conventional commits, as already mentioned in the contributing guidelines.
  • I squashed all your commits since fixes usually don't need an extra commit.

In the coming days I'll merge this one, thank you so much for your contribution ❤️

Immediately after the CI success notification from GH, I noticed the stupid br.json calling in locales where the file was actually named pt-br.json. 😅 Thank you for spotting that, and I'm glad to help! 🤩

@simonwep simonwep merged commit b4a9d15 into simonwep:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants