Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Update default homepage content #3001

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

thisisannie
Copy link
Contributor

@thisisannie thisisannie commented Sep 10, 2024

Description

  • Default home content should use "Silverstripe", not the old "SilverStripe"
  • External link should target blank
  • Developer lessons link should be removed as it points to CMS4 docs

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@thisisannie thisisannie marked this pull request as ready for review September 10, 2024 00:33
code/Model/SiteTree.php Outdated Show resolved Hide resolved
lang/en.yml Outdated Show resolved Hide resolved
emteknetnz

This comment was marked as outdated.

thisisannie and others added 2 commits September 11, 2024 11:01
Co-authored-by: Steve Boyd <[email protected]>
Co-authored-by: Steve Boyd <[email protected]>
@thisisannie thisisannie changed the title name-update: Rename SilverStripe Silverstripe ENH Update default homepage content Sep 10, 2024
@emteknetnz emteknetnz merged commit 1dab090 into silverstripe:5.2 Sep 11, 2024
15 checks passed
@emteknetnz
Copy link
Member

PR merged, it will be automatically tagged shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants