Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy errors #259

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Fix clippy errors #259

merged 3 commits into from
Jul 8, 2024

Conversation

ackintosh
Copy link
Member

@ackintosh ackintosh commented Jul 3, 2024 •
edited
Loading

Description

This PR fixes the clippy errors: https://github.com/sigp/discv5/actions/runs/9783383578/job/27016940537?pr=258

Notes & open questions

I removed ReceivedPacket because it no longer has the content field (as it was unused) and now only has the received field.

Change checklist

  • Self-review
  • [] Documentation updates if relevant
  • Tests if relevant

@ackintosh ackintosh mentioned this pull request Jul 3, 2024
Merged
2 tasks
@ackintosh ackintosh requested a review from AgeManning July 3, 2024 22:53
AgeManning
AgeManning approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@AgeManning AgeManning merged commit 7e63f13 into sigp:master Jul 8, 2024
6 checks passed
@ackintosh ackintosh deleted the fix-clippy-errors branch July 8, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ackintosh @AgeManning