chore: slim deps #255
Merged
chore: slim deps #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slim down the dependency tree by using `libp2p-identity` and `multiaddr` directly instead of `libp2p` when the `libp2p` feature is enabled
3 tasks
AgeManning
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
libp2pwithlibp2p-identityandmultiaddrwhich significantly lowers the amount of dependencies pulled in by the crate. Closes #253This PR also re-exports those two crates as they are needed to use some of the features introduced by the
libp2pfeature, so users end up adding the dependency in their tree manually on top. Closes #254Notes & open questions
Both changes are in their own commits, so I can split it off into two PRs if needed
Change checklist