Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to create default Instrumentation for operator based auto-instrumentation #836

Merged
merged 12 commits into from
Jul 13, 2023
Merged

Add support to create default Instrumentation for operator based auto-instrumentation #836

merged 12 commits into from
Jul 13, 2023

Conversation

jvoravong
Copy link
Contributor

Description:

  • This pull request introduces helm templates to facilitate the deployment of a default opentelemetry.io/v1alpha1 Instrumentation, eliminating the need for manual configuration by users.
  • The default Instrumentation includes the following features:
    • It sets the endpoint value for exporting traces. If the user does not provide an endpoint value, the traces will be exported to the collector agent or gateway.
    • Users have the flexibility to override default values by utilizing the operator.instrumentation.spec field, similar to how the agent configuration can be overridden using agent.config.
  • These changes bring us closer to the ability to create end-to-end tests for operator-based auto-instrumentation.

Testing:

  • Manual testing was conducted by directing auto-instrumented Java applications to send traces to the collector agent and gateway.

@jvoravong jvoravong requested review from a team as code owners June 27, 2023 22:27
@jvoravong jvoravong force-pushed the OTL-2167 branch 2 times, most recently from 5d63dfa to 3db1375 Compare June 27, 2023 22:33
@jvoravong jvoravong requested a review from dmitryax July 11, 2023 21:03
@jvoravong
Refactor update_java_agent.yaml to update_instrumentation_dependencie…
81bd753 
…s.yaml to support latest changes and adding other instrumentation libraries. Might require more updates after being merged to main.
@jvoravong
Remove done TODO
79cf10a
jvoravong
jvoravong commented Jul 13, 2023
View reviewed changes
.github/workflows/update_instrumentation_dependencies.yaml
runs-on: ubuntu-latest
strategy:
matrix:
language: ['java'] # Add other languages here
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to have automation extract the list value for this line, will add in a future PR if possible.

@jvoravong jvoravong requested a review from dmitryax July 13, 2023 18:57
@jvoravong jvoravong merged commit 6d3ca53 into signalfx:main Jul 13, 2023
7 checks passed
@jvoravong jvoravong deleted the OTL-2167 branch July 13, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvoravong @dmitryax