This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Use full artifact version during verification #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a problem when transitive dependencies ends up with the same name. Before this commit the following dependencies resulted in a verifcation error: Main dep: * foo-1.0.0.jar Transitive deps: * foo-platform-1.0.0-linux.jar * foo-platform-1.0.0-osx.jar * foo-platform-1.0.0-windows.jar In this case the dependencyVerification list had three entries containing the name 'foo-platform' with different checksums. This resulted in a conflict during verification. This commit makes use of all the info that follows the name to find the exact dependency, e.g. '1.0.0-linux' in this example.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a problem when transitive dependencies ends up with the
same name. Before this commit the following dependencies resulted in a
verifcation error:
Main dep:
Transitive deps:
In this case the dependencyVerification list had three entries
containing the name 'foo-platform' with different checksums. This
resulted in a conflict during verification.
This commit makes use of all the info that follows the name to find the
exact dependency, e.g. '1.0.0-linux' in this example.