Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of contacts for Android's "Quick Share" #13718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

genodeftest
Copy link

First time contributor checklist

Contributor checklist

  • None, as I do not currently have a setup to build Signal for Android and no way to test it with real contact data
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Work around a bug in Android which leads to non recent conversations showing up in Android's "Quick Share" overlay instead of the most recent conversations. As a side effect, leak less conversation names to the Android OS.

Fixes #13398

Notes:

  • The number 10 is arbitrarily chosen, as was the original number 150 if I understand commit 8783d15 correctly. On the Android UIs I have seen so far, there are only 4 or 5 "Quick Share" items to be displayed by the OS, but there may be other UIs. Feel free to adapt the number to whatever you think is more useful.
  • I don't have access to a machine that is suitable for building and testing this change at the moment. Can someone else please test this change for me?

Work around a bug in Android which lead to very non recent contacts showing up in Android's "Quick Share" overlay. Also increase privacy by leaking less conversation names to the Android UI.

Fixes signalapp#13398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Android "Share" menu does not display the most recent/shared-to contacts
1 participant