Fixes #13312: Delegate onConfigurationChanged to the ViewModel

[dautovicharis]

Contributor checklist

• I am following the Code Style Guidelines
• I have tested my contribution on these devices:

• Redmi Note 10 Pro, Android 13, MUI 14

• My contribution is fully baked and ready to be merged as is
• I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

---

Issue

Fixes: #13312

Description

In the beginning, I thought the problem had to do with the layout, but it turns out it's more about threads.

To make the layout hierarchy better, I tried taking out LinearLayout from onboarding_megaphone.xml. Unfortunately, this change didn't fix the issue.

After digging deeper, I found that the onConfigurationChanged method inside ConversationListFragment was incorrectly calling onMegaphoneChanged directly. It should go through lifecycleDisposable.

I tried to emit the current megaphone object using the following approach, but it didn't work because of the use of distinctUntilChanged():

fun onConfigurationChanged() {
    store.update { it.copy(megaphone = megaphone) }
}

Instead, I fetched the next megaphone object from the repository and updated the state.

fun onConfigurationChanged() {
    megaphoneRepository.getNextMegaphone { next ->
        store.update { it.copy(megaphone = next ?: Megaphone.NONE) }
    }
}

Final solution:
Moved onConfigurationChanged handling from ConversationListFragment to the ViewModel, ensuring consistency in UI updates via lifecycleDisposable and maintaining the guarantee of UI observations on the main thread.

Videos

fix.mov

Tested

Device	Android Version	Signal Version
Redmi Note 10 Pro		6.42.0

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been closed due to inactivity.